Bug 42562 – layout tests from changeset 56661 were missed

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Robert Hogan]

These tests were omitted from changeset 56661

See also webkit.org/n/32196

[Robert Hogan]

Created attachment 67297 [details]
Patch

[Eric Seidel (no email)]

Attachment 67297 [details] was posted by a committer and has review+, assigning to Robert Hogan for commit.

[WebKit Commit Bot]

Comment on attachment 67297 [details]
Patch

Rejecting patch 67297 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
/fast/forms .......
platform/mac/fast/loader .....
platform/mac/fast/objc ...
platform/mac/fast/overflow .
platform/mac/fast/text ............
platform/mac/fast/text/international ..
platform/mac/plugins ...........
platform/mac/scrollbars .
plugins ..
plugins/application-plugin-plugins-disabled.html -> failed

Exiting early after 1 failures. 18260 tests run.
393.52s total testing time

18259 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
10 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6379063

[Eric Seidel (no email)]

Looks like this patch isnt' quite right?  I assume someone else already resolved these missing results though?  Should this be closed?

[Robert Hogan]

Committed r74872: <http://trac.webkit.org/changeset/74872>

[WebKit Review Bot]

http://trac.webkit.org/changeset/74872 might have broken Leopard Intel Release (Tests), Leopard Intel Debug (Tests), SnowLeopard Intel Release (Tests), GTK Linux 32-bit Release, and GTK Linux 64-bit Debug
The following tests are not passing:
plugins/application-plugin-plugins-disabled.html

[Robert Hogan]

(In reply to comment #6)
> http://trac.webkit.org/changeset/74872 might have broken Leopard Intel Release (Tests), Leopard Intel Debug (Tests), SnowLeopard Intel Release (Tests), GTK Linux 32-bit Release, and GTK Linux 64-bit Debug
> The following tests are not passing:
> plugins/application-plugin-plugins-disabled.html

Fixed with http://trac.webkit.org/changeset/74876

[Kent Tamura]

Why application-plugin-plugins-disabled-expected.txt is placed in LayoutTests/plugin/, and it doesn't have the corresponding pixel result?

[Robert Hogan]

(In reply to comment #8)
> Why application-plugin-plugins-disabled-expected.txt is placed in LayoutTests/plugin/, and it doesn't have the corresponding pixel result?

I wasn't aware pixel results were mandatory. My setup would only allow me to generate a pixel result for qt or gtk - so not even sure they would be useful. All platforms for qt should have the same result as the one given in LayoutTests/plugins/ - bar minor metric differences.

[Eric Seidel (no email)]

Chromium runs pixel tests always.  The rest of the port should, but don't yet. :)  We used to run pixel tests for the Apple Mac port on the bots, but haven't in years.