| Summary: | Web Inspector: hide "toggle debugger" button when debugger is always enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bweinstein, joepeck, keishi, masterov, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Yury Semikhatsky
2010-07-19 05:03:43 PDT
Created attachment 61939 [details]
Patch
Comment on attachment 61939 [details] Patch Clearing flags on attachment: 61939 Committed r63649: <http://trac.webkit.org/changeset/63649> All reviewed patches have been landed. Closing bug. So, now how can the user turn the debugger off? Is it lazy initialized so that it is inactive until the user visits the Scripts panel? I don't like this change unless there is something I am missing. (In reply to comment #4) > So, now how can the user turn the debugger off? Is it lazy initialized so that > it is inactive until the user visits the Scripts panel? I don't like this change > unless there is something I am missing. This is not affecting WebKit/JSC. This was a regression on Chromium side that had debugger enabled for all times. We've lost this little diverging bit of UI while aligning with the upstream inspector code. Ahh, I see. Thanks for the explanation. (In reply to comment #4) > So, now how can the user turn the debugger off? Is it lazy initialized so that > it is inactive until the user visits the Scripts panel? I don't like this change > unless there is something I am missing. I had the same conversation on IRC a little earlier. :-) I think this would have been clearer if instead of Preferences.debuggerAlwaysEnabled it had been something like: Platform.debuggerAlwaysEnabled In this case, the "debuggerAlwaysEnabled" isn't really a "preference", it's a static state of the platform, or something. Always true for V8, always false for JSC, at least at that point in the code. If you just went by the name alone, you'd guess, as I and probably Joe did, that this was the state associated with the radio button in the "enable script debugging" panel. A comment would have also made this clear. |