Bug 4255

Summary: underlines still print too thick
Product: WebKit Reporter: Trey Matteson <trey>
Component: PrintingAssignee: Trey Matteson <trey>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.nytimes.com/
Attachments:
Description Flags
proposed patch sullivan: review+

Trey Matteson
Reported 2005-08-01 11:52:35 PDT
Load any page with links. Print. The underlines under the links are too thick, especially compared to how they look on the screen. #4226 improved this a bit, but it still needs work.
Attachments
proposed patch (1.97 KB, patch)
2005-08-01 14:10 PDT, Trey Matteson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Trey Matteson
Comment 1 2005-08-01 12:05:29 PDT
Here is a particularly bad case: Set the scale in Page Setup to 50%. Now Print. The underlines are extra thick. The problem is that drawLineForCharacters: in WebTextRenderer sets an absolute thickness for lines of 0 thickness. It applies the inverse CTM to pick a size that will be fixed on the paper, regardless of any scaling.
Trey Matteson
Comment 2 2005-08-01 14:10:34 PDT
Created attachment 3199 [details] proposed patch
John Sullivan
Comment 3 2005-08-01 14:30:06 PDT
Comment on attachment 3199 [details] proposed patch I tried this out, and it's a very noticeable improvement. I'll check this in shortly.
John Sullivan
Comment 4 2005-08-01 14:35:29 PDT
Checked in.
Note You need to log in before you can comment on or make changes to this bug.