Bug 4255 - underlines still print too thick
Summary: underlines still print too thick
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Trey Matteson
URL: http://www.nytimes.com/
Depends on:
Reported: 2005-08-01 11:52 PDT by Trey Matteson
Modified: 2005-08-01 14:35 PDT (History)
0 users

See Also:

proposed patch (1.97 KB, patch)
2005-08-01 14:10 PDT, Trey Matteson
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trey Matteson 2005-08-01 11:52:35 PDT
Load any page with links.  Print.  The underlines under the links are too thick, especially compared to how 
they look on the screen.

#4226 improved this a bit, but it still needs work.
Comment 1 Trey Matteson 2005-08-01 12:05:29 PDT
Here is a particularly bad case:  Set the scale in Page Setup to 50%.  Now Print.  The underlines are extra 

The problem is that drawLineForCharacters: in WebTextRenderer sets an absolute thickness for lines of 0 
thickness.  It applies the inverse CTM to pick a size that will be fixed on the paper, regardless of any 
Comment 2 Trey Matteson 2005-08-01 14:10:34 PDT
Created attachment 3199 [details]
proposed patch
Comment 3 John Sullivan 2005-08-01 14:30:06 PDT
Comment on attachment 3199 [details]
proposed patch

I tried this out, and it's a very noticeable improvement. I'll check this in
Comment 4 John Sullivan 2005-08-01 14:35:29 PDT
Checked in.