Bug 42519

Summary: Begin work on NPRuntime support
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2010-07-18 11:50:35 PDT
Begin work on NPRuntime support
Attachments
Patch (6.51 KB, patch)
2010-07-18 11:51 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-18 11:51:56 PDT
Created attachment 61905 [details] Patch
WebKit Review Bot
Comment 2 2010-07-18 11:53:51 PDT
Attachment 61905 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:151: NPN_GetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:154: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-18 11:59:44 PDT
Committed r63629: <http://trac.webkit.org/changeset/63629>
Note You need to log in before you can comment on or make changes to this bug.