Bug 42519 - Begin work on NPRuntime support
Summary: Begin work on NPRuntime support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-18 11:50 PDT by Anders Carlsson
Modified: 2010-07-18 11:59 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.51 KB, patch)
2010-07-18 11:51 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-18 11:50:35 PDT
Begin work on NPRuntime support
Comment 1 Anders Carlsson 2010-07-18 11:51:56 PDT
Created attachment 61905 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-18 11:53:51 PDT
Attachment 61905 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:151:  NPN_GetValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:154:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-18 11:59:44 PDT
Committed r63629: <http://trac.webkit.org/changeset/63629>