| Summary: | [Web Timing] Move times to DocumentLoader and fix bugs in mark points | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fishd, pfeldman | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 30685 | ||||||
| Attachments: |
|
||||||
|
Description
Tony Gentilcore
2010-07-17 21:46:08 PDT
Created attachment 61906 [details]
Patch
I believe this fixes the last of the critical web timing bugs. Sorry for the big patch, but maybe its actually good to review all of the marks in one place. Comment on attachment 61906 [details]
Patch
WebCore/loader/DocumentLoader.h:208
+ DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; }
one minor suggestion: you could probably get away with shortening this member
function to "timing()" as the "documentLoad" prefix is sort of redundant with the
name of the class, DocumentLoader.
R=me
(In reply to comment #3) > (From update of attachment 61906 [details]) > WebCore/loader/DocumentLoader.h:208 > + DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; } > one minor suggestion: you could probably get away with shortening this member > function to "timing()" as the "documentLoad" prefix is sort of redundant with the > name of the class, DocumentLoader. Thanks! Fixed and landing. > > R=me Committed r63689: <http://trac.webkit.org/changeset/63689> |