Bug 42466

Summary: Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, levin, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Hans Wennborg
Reported 2010-07-16 10:13:16 PDT
Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
Attachments
Patch (2.09 KB, patch)
2010-07-16 10:17 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (2.05 KB, patch)
2010-07-17 09:37 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2010-07-16 10:17:25 PDT
Created attachment 61821 [details] Patch
David Levin
Comment 2 2010-07-16 10:27:17 PDT
Comment on attachment 61821 [details] Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 4558db60cf53f1b2d7bdc4fddb487c8516f91d66..079c9321a32ab8ba68b3b37fb35ed13fade0533a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,21 @@ > +2010-07-16 Hans Wennborg <hans@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file > + https://bugs.webkit.org/show_bug.cgi?id=42466 > + > + This avoids needing to have the full declaration of DeviceOrientation > + in DeviceOrientationEvent.h, which was otherwise necessary because > + of the implicit destructor. Consider moving this comment (and shortening) to be where the function is listed in the ChangeLog. > + (Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447) > + > + No new tests. (OOPS!) This should be removed -- perhaps replaced by "No new functionality so no new tests.". > + > + * dom/DeviceOrientationEvent.cpp: > + (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Right here. Something like: "Move here to voids needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h" > + * dom/DeviceOrientationEvent.h: r- due to OOPS for no new tests (as this won't auto-commit).
Hans Wennborg
Comment 3 2010-07-17 09:37:32 PDT
Created attachment 61884 [details] Patch
Steve Block
Comment 4 2010-07-19 01:56:42 PDT
Comment on attachment 61884 [details] Patch r=me
WebKit Commit Bot
Comment 5 2010-07-19 02:40:37 PDT
Comment on attachment 61884 [details] Patch Clearing flags on attachment: 61884 Committed r63646: <http://trac.webkit.org/changeset/63646>
WebKit Commit Bot
Comment 6 2010-07-19 02:40:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.