Summary: | DeviceOrientationEvent.h should not forward-declare DeviceOrientation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Hans Wennborg
2010-07-16 04:51:10 PDT
Created attachment 61795 [details]
Patch
Comment on attachment 61795 [details]
Patch
r=me
Comment on attachment 61795 [details] Patch Clearing flags on attachment: 61795 Committed r63544: <http://trac.webkit.org/changeset/63544> All reviewed patches have been landed. Closing bug. Adding the include is one solution in a case like this. Another is to explicitly declare the virtual destructor and define it in the .cpp file. It will have just an empty body, but it will make sure that people who include the header don’t have to compile the destructor. (In reply to comment #5) > Adding the include is one solution in a case like this. Another is to explicitly declare the virtual destructor and define it in the .cpp file. It will have just an empty body, but it will make sure that people who include the header don’t have to compile the destructor. Ah, I didn't think of that. Do you think we should change it? |