Bug 42438

Summary: Add directional property enums to the switch in applyProperty
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch levin: review+

Erik Arvidsson
Reported 2010-07-15 19:42:49 PDT
Add directional property enums to the switch in applyProperty
Attachments
Patch (2.24 KB, patch)
2010-07-15 19:44 PDT, Erik Arvidsson 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2010-07-15 19:44:10 PDT
Created attachment 61758 [details] Patch
David Levin
Comment 2 2010-07-15 19:55:46 PDT
Comment on attachment 61758 [details] Patch I wish there was a "cleaner" way of doing it. (In fact, I can think of one but it involves macros and perhaps a little trickiness so maybe it wouldn't be that great.) Here's the shape of what I'm thinking of. A "header" file with a list like this. CSS_DIRECTION_AWARE_PROPERTY(CSSPropertyWebkitMarginEnd, CSSPropertyMarginRight, CSSPropertyMarginLeft) Anyway what you have here will work.
Erik Arvidsson
Comment 3 2010-07-15 20:03:01 PDT
Committed r63509: <http://trac.webkit.org/changeset/63509>
Note You need to log in before you can comment on or make changes to this bug.