Bug 42428

Summary: [chromium] new svg failures after r63485
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: anicolao, commit-queue, eric, jorlow, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 43102    
Bug Blocks: 43182    
Attachments:
Description Flags
Patch none

Ojan Vafai
Reported 2010-07-15 17:19:07 PDT
svg/custom/convolution-crash.svg fails the pixel test on mac svg/W3C-SVG-1.1/filters-conv-01-f.svg goes from crashing to pixel+text failure on linux/win and goes from passing to failing pixel on mac.
Attachments
Patch (4.42 KB, patch)
2010-07-28 22:31 PDT, Alex Nicolaou 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-07-16 10:36:48 PDT
It looks like the expected png/checksum checked in for svg/custom/convolution-crash.svg with r63485 matched chrome linux/win, not mac. http://trac.webkit.org/changeset/63534 fixes that. Now it fails on all chromium platforms.
Alex Nicolaou
Comment 2 2010-07-27 22:49:48 PDT
I have new baselines for these but they depend on a code change in bug 43102
Ojan Vafai
Comment 3 2010-07-28 16:13:23 PDT
FWIW, it would be OK to commit the new baselines for these as part of the patch for bug 43102.
Alex Nicolaou
Comment 4 2010-07-28 22:31:43 PDT
Created attachment 62917 [details] Patch
Alex Nicolaou
Comment 5 2010-07-28 22:35:45 PDT
*** Bug 43104 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 6 2010-07-29 01:22:37 PDT
Comment on attachment 62917 [details] Patch Clearing flags on attachment: 62917 Committed r64266: <http://trac.webkit.org/changeset/64266>
WebKit Commit Bot
Comment 7 2010-07-29 01:22:42 PDT
All reviewed patches have been landed. Closing bug.
Alex Nicolaou
Comment 8 2010-07-29 02:35:17 PDT
The convolution crash failure introduced here is fixed by a new baseline in bug 43182
Jeremy Orlow
Comment 9 2010-07-29 03:30:33 PDT
Oops...posted to the wrong bug originally: FYI: Added a baseline to chromium for svg/custom/convolution-crash.svg : http://trac.webkit.org/changeset/64268
Note You need to log in before you can comment on or make changes to this bug.