Bug 42406

Summary:

minor fixes to sunspider to simplify automation

Product:

WebKit

Reporter:

Stephanie Lewis <slewis>

Component:

Tools / Tests

Assignee:

Stephanie Lewis <slewis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, slewis

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
patch	ggaren: review+, commit-queue: commit-queue-

Stephanie Lewis

Reported 2010-07-15 14:13:07 PDT

Created attachment 61717 [details] patch A couple of minor fixes to SunSpider to simplify running in automated test harness.

Attachments
patch (2.74 KB, patch) 2010-07-15 14:13 PDT, Stephanie Lewis	no flags	Details Formatted Diff Diff
patch (2.85 KB, patch) 2010-07-15 14:15 PDT, Stephanie Lewis	ggaren: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Stephanie Lewis

Comment 1 2010-07-15 14:15:22 PDT

Created attachment 61718 [details] patch include bug number in Changelogs

Geoffrey Garen

Comment 2 2010-07-15 14:26:49 PDT

Comment on attachment 61718 [details] patch r=me

Adam Barth

Comment 3 2010-08-10 22:33:26 PDT

Comment on attachment 61718 [details] patch Shall we land this patch?

WebKit Commit Bot

Comment 4 2010-08-11 04:26:10 PDT

Comment on attachment 61718 [details] patch Rejecting patch 61718 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1 Last 500 characters of output: patching file SunSpider/sunspider Hunk #1 succeeded at 231 with fuzz 2 (offset 2 lines). patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/sunspider-compare-results Hunk #1 FAILED at 55. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/sunspider-compare-results.rej patching file WebKitTools/Scripts/webkitdirs.pm Hunk #1 FAILED at 258. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitdirs.pm.rej Full output: http://queues.webkit.org/results/3717049

Eric Seidel (no email)

Comment 5 2010-10-13 12:26:43 PDT

Attachment 61718 [details] was posted by a committer and has review+, assigning to Stephanie Lewis for commit.

Stephanie Lewis

Comment 6 2010-10-13 14:14:29 PDT

oops, I forgot to close this bug. Sorry! Landed in http://trac.webkit.org/projects/webkit/changeset/63463

Note You need to log in before you can comment on or make changes to this bug.