Bug 42406 - minor fixes to sunspider to simplify automation
Summary: minor fixes to sunspider to simplify automation
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Stephanie Lewis
Depends on:
Reported: 2010-07-15 14:13 PDT by Stephanie Lewis
Modified: 2010-10-13 14:14 PDT (History)
3 users (show)

See Also:

patch (2.74 KB, patch)
2010-07-15 14:13 PDT, Stephanie Lewis
no flags Details | Formatted Diff | Diff
patch (2.85 KB, patch)
2010-07-15 14:15 PDT, Stephanie Lewis
ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2010-07-15 14:13:07 PDT
Created attachment 61717 [details]

A couple of minor fixes to SunSpider to simplify running in automated test harness.
Comment 1 Stephanie Lewis 2010-07-15 14:15:22 PDT
Created attachment 61718 [details]

include bug number in Changelogs
Comment 2 Geoffrey Garen 2010-07-15 14:26:49 PDT
Comment on attachment 61718 [details]

Comment 3 Adam Barth 2010-08-10 22:33:26 PDT
Comment on attachment 61718 [details]

Shall we land this patch?
Comment 4 WebKit Commit Bot 2010-08-11 04:26:10 PDT
Comment on attachment 61718 [details]

Rejecting patch 61718 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1
Last 500 characters of output:
patching file SunSpider/sunspider
Hunk #1 succeeded at 231 with fuzz 2 (offset 2 lines).
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/sunspider-compare-results
Hunk #1 FAILED at 55.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/sunspider-compare-results.rej
patching file WebKitTools/Scripts/webkitdirs.pm
Hunk #1 FAILED at 258.
1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitdirs.pm.rej

Full output: http://queues.webkit.org/results/3717049
Comment 5 Eric Seidel (no email) 2010-10-13 12:26:43 PDT
Attachment 61718 [details] was posted by a committer and has review+, assigning to Stephanie Lewis for commit.
Comment 6 Stephanie Lewis 2010-10-13 14:14:29 PDT
oops, I forgot to close this bug.  Sorry!

Landed in http://trac.webkit.org/projects/webkit/changeset/63463