Bug 42401

Summary: Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, fishd, japhet, oliver, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch japhet: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-07-15 13:47:59 PDT
The query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by the WebGL implementation rather than delegating to the underlying OpenGL API, because WebGL 1.0 does not support compressed textures and must return 0 for this query.
Attachments
Patch (2.80 KB, patch)
2010-07-15 13:55 PDT, Kenneth Russell 		japhet: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-07-15 13:55:40 PDT
Created attachment 61715 [details] Patch
Nate Chapin
Comment 2 2010-07-15 14:02:23 PDT
Comment on attachment 61715 [details] Patch Per offline conversation, please add a comment explaining why we're hard-coding a 0 before submitting. > case GraphicsContext3D::NUM_COMPRESSED_TEXTURE_FORMATS: > - return getLongParameter(pname); > + return WebGLGetInfo(static_cast<long>(0));
Kenneth Russell
Comment 3 2010-07-15 14:05:50 PDT
Committed r63460: <http://trac.webkit.org/changeset/63460>
Note You need to log in before you can comment on or make changes to this bug.