Bug 42389

Summary: Add leakRef and clear to all RefPtr variants
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Darin Adler
Reported 2010-07-15 11:29:17 PDT
Add leakRef and clear to all RefPtr variants
Attachments
Patch (39.34 KB, patch)
2010-07-15 11:49 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-07-15 11:49:03 PDT
Created attachment 61697 [details] Patch
WebKit Review Bot
Comment 2 2010-07-15 19:07:40 PDT
Attachment 61697 [details] did not build on win: Build output: http://webkit-commit-queue.appspot.com/results/3401449
Adam Barth
Comment 3 2010-08-06 20:10:32 PDT
Darin, did you want to land this patch?
Darin Adler
Comment 4 2010-08-08 17:41:49 PDT
Yes, I am planning to and have not had time to yet.
Adam Barth
Comment 5 2010-08-08 18:28:03 PDT
I'd be happy to do it for you if you'd rather spend that time reviewing patches. :)
Darin Adler
Comment 6 2010-08-08 21:40:14 PDT
If you want to land it, that would be fine with me. But there may be merging necessary due to changes related to WARN_UNUSED_RETURN.
Adam Barth
Comment 7 2010-08-10 23:17:18 PDT
I have a merged version locally. Attempting to land.
Adam Barth
Comment 8 2010-08-11 00:08:41 PDT
Committed r65130: <http://trac.webkit.org/changeset/65130>
Note You need to log in before you can comment on or make changes to this bug.