Summary: | Add possibility to dumpAsText and generate a pixel test result | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||
Component: | Tools / Tests | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, mjs, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=258298 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 42376 | ||||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-07-15 07:47:51 PDT
Created attachment 61661 [details]
Patch
Maciej, do you think that would be acceptable?
Attachment 61661 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/wx/DumpRenderTreeWx.cpp:206: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The style failure is in existing code, I'll fix it before landing (if this patch gets a positive review). Created attachment 61774 [details]
Updated patch
Updated patch after IRC discussion with Maciej.
Attachment 61774 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/wx/DumpRenderTreeWx.cpp:206: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Oops, fixed style issue (not uploading a new patch to let EWS run) Attachment 61774 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3413423 Created attachment 61778 [details]
Updated patch v2
Fix style issue and chromium build.
Issue 1: float* totals is passed from fastSetInteriorPixels, and the new helper function setDestinationPixels is called multiple times. That means you're doing the divisior division multiple times, accumulated! for (int i = 0; i < numTotals; ++i) totals[i] = totals[i] / divisor + bias; Issue 2: for (int i = 0; i < 3; ++i) image->set(pixel++, clampRGBAValue(totals[0], maxAlpha)); You're always clamping totals[0], not totals[i]. Very evil! Oops, ignore that commented on wrong br. Comment on attachment 61778 [details]
Updated patch v2
LGTM r=me
Discussed the concept with Maciej, he was fine with it. Landed in r63536. |