Bug 42372

Summary:

Web Inspector: differentiate between blocking and connecting timers.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	yurys: review-
[PATCH] Fixed typos, added cached reporting branch.	yurys: review+
[PATCH] To land.	none

Pavel Feldman

Reported 2010-07-15 07:13:37 PDT

Also contains couple of drive-by fixes: - allows setting "cached" after the resource graph has been created. - prevents inspector from getting information about the same resource twice in case areMemoryCacheClientCallsEnabled == true.

Attachments
[PATCH] Proposed change. (14.70 KB, patch) 2010-07-15 07:17 PDT, Pavel Feldman	yurys: review-	Details Formatted Diff Diff
[PATCH] Fixed typos, added cached reporting branch. (15.22 KB, patch) 2010-07-15 07:30 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
[PATCH] To land. (15.22 KB, patch) 2010-07-15 07:40 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-07-15 07:17:31 PDT

Created attachment 61655 [details] [PATCH] Proposed change.

Yury Semikhatsky

Comment 2 2010-07-15 07:28:47 PDT

Comment on attachment 61655 [details] [PATCH] Proposed change. WebCore/loader/FrameLoader.cpp:3080 + page->inspectorController()->didLoadResourceFromMemoryCache(m_documentLoader.get(), resource); You seem to miss this call from the next branch. WebCore/inspector/InspectorResource.cpp:67 + , m_connection(false) What is this?

Pavel Feldman

Comment 3 2010-07-15 07:30:33 PDT

Created attachment 61657 [details] [PATCH] Fixed typos, added cached reporting branch.

Yury Semikhatsky

Comment 4 2010-07-15 07:37:03 PDT

Comment on attachment 61657 [details] [PATCH] Fixed typos, added cached reporting branch. WebCore/loader/FrameLoader.cpp:3080 + page->inspectorController()->didLoadResourceFromMemoryCache(m_documentLoader.get(), resource); Would be nice if we could get rid of duplicating this call.

Pavel Feldman

Comment 5 2010-07-15 07:40:20 PDT

Created attachment 61659 [details] [PATCH] To land.

Pavel Feldman

Comment 6 2010-07-15 08:04:10 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/InspectorResource.h M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/inspector.js M WebCore/loader/FrameLoader.cpp M WebCore/platform/network/ResourceResponseBase.cpp M WebCore/platform/network/ResourceResponseBase.h M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebURLResponse.h M WebKit/chromium/src/WebURLResponse.cpp Committed r63425

Note You need to log in before you can comment on or make changes to this bug.