Bug 42352

Summary: Text layout is wrong with SVG Font that lacks <missing-glyph> element
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
a reproduction.
none
patch v0 zimmermann: review+

Description Hajime Morrita 2010-07-15 02:55:44 PDT 
Created attachment 61629 [details]
a reproduction.

Text layout goes wrong when:

- There is a text styled with SVG Font
- The text has a character whose glyph is NOT contained in the SVG font.
- The SVG font does not have <missing-glypph>

This problem is originally reported http://code.google.com/p/chromium/issues/detail?id=48949 but not chromium specific.
Comment 1 Hajime Morrita 2010-07-15 03:44:43 PDT 
Created attachment 61633 [details]
patch v0
Comment 2 Nikolas Zimmermann 2010-07-15 04:22:14 PDT 
Comment on attachment 61633 [details]
patch v0

Great patch! Please fix typo before landing.

WebCore/ChangeLog:7
 +          sub-run, and a fallback to system font triggers such a comutation.
Typo: computation.
Comment 3 Hajime Morrita 2010-07-15 05:00:52 PDT 
Thank you for the lightning review!
I'll land this after fix the typo.
Comment 4 Hajime Morrita 2010-07-15 05:54:58 PDT 
Committed r63422: <http://trac.webkit.org/changeset/63422>