Bug 42348

Summary: fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Adam Barth 2010-07-15 02:45:25 PDT 
fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
Comment 1 Adam Barth 2010-07-15 02:47:08 PDT 
Created attachment 61625 [details]
Patch
Comment 2 Darin Adler 2010-07-15 09:37:00 PDT 
Comment on attachment 61625 [details]
Patch

> +        This doesn't work in the HTML5 parser.  We cover this behavior in
> +        parsing tests.  Sadly, the test still failes under the HTML5 parser,
> +        but for a different reason.

One space after period. Typo in the word "failes".
Comment 3 Adam Barth 2010-07-15 09:38:06 PDT 
Comment on attachment 61625 [details]
Patch

Thanks.
Comment 4 Adam Barth 2010-07-15 13:36:02 PDT 
Created attachment 61709 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-07-15 17:34:54 PDT 
Comment on attachment 61709 [details]
Patch for landing

Rejecting patch 61709 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
eLog
	M	LayoutTests/fast/events/focusingUnloadedFrame.html
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/LayoutTests/fast/events/focusingUnloadedFrame.html

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3420284
Comment 6 Adam Barth 2010-07-19 18:30:34 PDT 
Created attachment 62022 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2010-07-20 01:31:28 PDT 
Comment on attachment 62022 [details]
Patch for landing

Clearing flags on attachment: 62022

Committed r63733: <http://trac.webkit.org/changeset/63733>
Comment 8 WebKit Commit Bot 2010-07-20 01:31:32 PDT 
All reviewed patches have been landed.  Closing bug.