| Summary: | LegacyHTMLTreeBuilder should insert an implicit <colgroup> before inserting <col> to match HTML5 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, hyatt, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | 42404 | ||||||||
| Bug Blocks: | 41123 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2010-07-15 02:31:47 PDT
Hyatt might like to see the table changes go by. Created attachment 61624 [details]
Patch
Comment on attachment 61624 [details]
Patch
The code change looks fine, but the diffs to insertCols and deleteCols look suspect. We need to understand more about what those tests are trying to do.
Yeah, those tests now "fail" since they assume that the "col" will be a direct child of the "table". Minefield "fails" the test the same way we do now. Would be interesting to see why HTML5 is adding the implicit <colgroup>. It's possible that those tests would fail in IE too. Created attachment 61721 [details]
Patch
This is just Eric's patch with the results updated after the {insert|delete}Cols{1,2,3} tests are fixed in Bug 42404.
Comment on attachment 61721 [details]
Patch
I think this patch is now correct. Might be another fun landing. :-/
Comment on attachment 61721 [details]
Patch
Thanks Adam.
Comment on attachment 61721 [details] Patch Clearing flags on attachment: 61721 Committed r63472: <http://trac.webkit.org/changeset/63472> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/63472 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/63472 http://trac.webkit.org/changeset/63473 |