Bug 42310

Summary: Make sure that mixed interpreter/jit builds don't try to use the jit if the allocator fails
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2010-07-14 19:08:07 PDT
Make sure that mixed interpreter/jit builds don't try to use the jit if the allocator fails
Attachments
Patch (25.76 KB, patch)
2010-07-14 19:14 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-07-14 19:14:43 PDT
Created attachment 61596 [details] Patch
WebKit Review Bot
Comment 2 2010-07-14 19:20:38 PDT
Attachment 61596 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:453: lock_holder is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:461: lock_holder is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:470: lock_holder is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2010-07-14 21:30:29 PDT
Committed r63404: <http://trac.webkit.org/changeset/63404>
Note You need to log in before you can comment on or make changes to this bug.