Summary: | More work on plug-in streams | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dbates, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2010-07-14 17:42:59 PDT
Created attachment 61591 [details]
Patch
Attachment 61591 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:60: NPP_New is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:61: NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:63: NPP_NewStream is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:64: NPP_DestroyStream is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:80: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:90: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:151: NetscapePlugin::NPP_NewStream is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:156: NetscapePlugin::NPP_DestroyStream is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 9 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r63385: <http://trac.webkit.org/changeset/63385> This change broke the Apple Windows build bots. There are unresolved externals symbols: See <http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/19414/steps/compile-webkit/logs/stdio>. I checked in a speculative build fix, let's see if it's enough. http://trac.webkit.org/changeset/63385 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/63384 http://trac.webkit.org/changeset/63385 http://trac.webkit.org/changeset/63386 http://trac.webkit.org/changeset/63389 http://trac.webkit.org/changeset/63383 |