Bug 42308 – More work on plug-in streams

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

More work on plug-in streams

[Anders Carlsson]

Created attachment 61591 [details]
Patch

[WebKit Review Bot]

Attachment 61591 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:60:  NPP_New is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:61:  NPP_Destroy is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:63:  NPP_NewStream is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:64:  NPP_DestroyStream is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:80:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:90:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:151:  NetscapePlugin::NPP_NewStream is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:156:  NetscapePlugin::NPP_DestroyStream is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 9 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r63385: <http://trac.webkit.org/changeset/63385>

[Daniel Bates]

This change broke the Apple Windows build bots. There are unresolved externals symbols:

See <http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/19414/steps/compile-webkit/logs/stdio>.

[Anders Carlsson]

I checked in a speculative build fix, let's see if it's enough.

[WebKit Review Bot]

http://trac.webkit.org/changeset/63385 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63384
http://trac.webkit.org/changeset/63385
http://trac.webkit.org/changeset/63386
http://trac.webkit.org/changeset/63389
http://trac.webkit.org/changeset/63383