Bug 42303

Summary: Backfill DNS and connect times rather than exposing hard zeros
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30685    
Attachments:
Description Flags
Patch fishd: review+, fishd: commit-queue-

Tony Gentilcore
Reported 2010-07-14 16:46:11 PDT
Backfill DNS and connect times rather than exposing hard zeros
Attachments
Patch (6.45 KB, patch)
2010-07-14 17:04 PDT, Tony Gentilcore 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-07-14 17:04:21 PDT
Created attachment 61583 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-07-14 23:50:34 PDT
Comment on attachment 61583 [details] Patch WebCore/page/Timing.cpp:58 + static unsigned long long toIntegerMilliseconds(double milliseconds) nit: move to the top of the file so that the Timing methods are not interrupted by a non-Timing method. it isn't a real readability issue now, but once you add an interrupt like this, someone will add more, and pretty soon you'll get half of your class implemented in one section of the file and the other half in another :( R=me
Tony Gentilcore
Comment 3 2010-07-15 08:13:36 PDT
(In reply to comment #2) > (From update of attachment 61583 [details]) > WebCore/page/Timing.cpp:58 > + static unsigned long long toIntegerMilliseconds(double milliseconds) > nit: move to the top of the file so that the Timing methods are not interrupted > by a non-Timing method. it isn't a real readability issue now, but once you > add an interrupt like this, someone will add more, and pretty soon you'll get > half of your class implemented in one section of the file and the other half > in another :( > Make sense. Done. > > R=me
Tony Gentilcore
Comment 4 2010-07-15 08:16:13 PDT
Committed r63426: <http://trac.webkit.org/changeset/63426>
Note You need to log in before you can comment on or make changes to this bug.