Bug 42301

Summary: [Chromium] Use the unique ID instead of the profile label to identify the accepted AutoFill suggestion.
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dhollowa, fishd, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch fishd: review+, fishd: commit-queue-

James Hawkins
Reported 2010-07-14 16:05:32 PDT
[Chromium] Use the unique ID instead of the profile label to identify the accepted AutoFill suggestion.
Attachments
Patch (11.27 KB, patch)
2010-07-14 16:06 PDT, James Hawkins 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-07-14 16:06:53 PDT
Created attachment 61579 [details] Patch
David Holloway
Comment 2 2010-07-14 16:31:39 PDT
LGTM.
Darin Fisher (:fishd, Google)
Comment 3 2010-07-14 16:55:37 PDT
Comment on attachment 61579 [details] Patch WebKit/chromium/public/WebView.h:258 + // Notifies the WebView that AutoFill suggestions are available for a node. it might be nice to explain what the uniqueIDs parameter is all about. it isn't very obvious from reading the signature of the method. R=me
James Hawkins
Comment 4 2010-07-14 17:20:08 PDT
Committed r63379: <http://trac.webkit.org/changeset/63379>
James Robinson
Comment 5 2010-07-14 18:00:07 PDT
This doesn't compile in debug. WebViewImpl.cpp:1740
Note You need to log in before you can comment on or make changes to this bug.