Bug 42296

Summary: Add NetscapePluginStream class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2010-07-14 15:33:40 PDT
Add NetscapePluginStream class
Attachments
Patch (9.93 KB, patch)
2010-07-14 15:34 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-14 15:34:34 PDT
Created attachment 61575 [details] Patch
Darin Adler
Comment 2 2010-07-14 15:36:02 PDT
Comment on attachment 61575 [details] Patch > +NetscapePluginStream::NetscapePluginStream(NetscapePlugin* plugin, uint64_t streamID, bool sendNotification, void* notificationData) bool is no fun > + NetscapePluginStream(NetscapePlugin* plugin, uint64_t streamID, bool sendNotification, void* notificationData); No need for the argument name "plugin". > + RefPtr<NetscapePlugin> m_plugin; If this class holds a ref to the plugin then the argument should be PassRefPtr<NetscapePlugin>, not NetscapePlugin*.
Anders Carlsson
Comment 3 2010-07-14 15:53:46 PDT
Committed r63364: <http://trac.webkit.org/changeset/63364>
Note You need to log in before you can comment on or make changes to this bug.