Bug 42287

Summary: Add NetscapePlugin::NPP_ member functions for calling into the plug-in
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-07-14 13:33:40 PDT
Add NetscapePlugin::NPP_ member functions for calling into the plug-in
Attachments
Patch (4.51 KB, patch)
2010-07-14 13:34 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-14 13:34:40 PDT
Created attachment 61560 [details] Patch
WebKit Review Bot
Comment 2 2010-07-14 13:36:50 PDT
Attachment 61560 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:55: NPP_New is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:56: NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:57: NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:58: NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:111: NetscapePlugin::NPP_New is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:116: NetscapePlugin::NPP_Destroy is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:121: NetscapePlugin::NPP_SetWindow is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:126: NetscapePlugin::NPP_URLNotify is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 8 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-14 13:49:53 PDT
Committed r63351: <http://trac.webkit.org/changeset/63351>
Note You need to log in before you can comment on or make changes to this bug.