Bug 42283

Summary:

Define setPrivateBrowsingEnabled()

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41801

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Robert Hogan

Reported 2010-07-14 13:21:26 PDT

'Private Browsing' actually doesn't have a formal definition in WebCore - at least not in the code. WebKit on the other hand is not short of possible definitions: \value PrivateBrowsingEnabled Private browsing prevents WebKit from recording visited pages in the history and storing web page icons. This is disabled by default. @abstract If private browsing is enabled, WebKit will not store information about sites the user visits. * Whether to enable private browsing mode. Private browsing mode prevents * WebKit from updating the global history and storing any session * information e.g., on-disk cache, as well as suppressing any messages * from being printed into the (javascript) console. Ports are at liberty to implement their own additional behaviour to private browsing, and clients even more. Define 'private browsing' in WebCore so that it is not subject to feature creep (such as protecting against remote tracking) and potential confusion (what clients brand 'private browsing' may not be within the scope of WebCore's definition of private browsing).

Attachments
Patch (1.63 KB, patch) 2010-07-16 03:06 PDT, Robert Hogan	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2010-07-16 03:06:18 PDT

Created attachment 61789 [details] Patch

Antonio Gomes

Comment 2 2010-07-16 06:35:10 PDT

good stuff!

Adam Barth

Comment 3 2010-07-27 07:15:55 PDT

Comment on attachment 61789 [details] Patch WebCore/ChangeLog:6 + Please remove these extra spaces before landing.

Adam Barth

Comment 4 2010-08-06 20:37:53 PDT

Committed r64893: <http://trac.webkit.org/changeset/64893>

Note You need to log in before you can comment on or make changes to this bug.