| Summary: | Fix enum value names for Navigation.{idl|h} | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bulach, darin, japhet | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 30685 | ||||||
| Attachments: |
|
||||||
Created attachment 61555 [details]
Patch
Comment on attachment 61555 [details] Patch > + enum NavigationType { > + NAVIGATE = 0, > + RELOAD = 1, > + BACK_FORWARD = 2, > + }; I don’t think it’s important to have those "= 0", "= 1", "= 2" there. I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file. (In reply to comment #2) > (From update of attachment 61555 [details]) > > + enum NavigationType { > > + NAVIGATE = 0, > > + RELOAD = 1, > > + BACK_FORWARD = 2, > > + }; > > I don’t think it’s important to have those "= 0", "= 1", "= 2" there. Okay, I'll pull them. > > I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file. DontCheckEnum was not added to this IDL file because it is guarded by ENABLE(WEB_TIMING), which is currently off by default. I got the compile error as soon as I enabled it locally. Committed r63356: <http://trac.webkit.org/changeset/63356> |
Fix enum value names for Navigation.{idl|h}