Bug 42261
| Summary: | #if !PLATFORM(CG) a bit confusing as a mechanism to decide how to handle ImageBuffer colorspace conversion | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Nicolaou <anicolao> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, krit, zimmermann |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 42228 | ||
| Bug Blocks: | |||
Alex Nicolaou
In https://bugs.webkit.org/show_bug.cgi?id=42228#c11 Darin complained that the way we're deciding to do the colorspace conversion or not at the call sites that get pixels from an ImageBuffer that isn't in device colorspace is confusing. We could fix this by adding some other #define to key off of or by burying the decision making in the ImageBuffer class itself; this bug is meant for us to pick an approach so that I can implement it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alex Nicolaou
Add backlink to bug 42228
Dirk Schulze
It is not decided at caller site anymore.