Bug 42233

Summary: HTMLTreeBuilder needs to update to match new spec behavior for <button>
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-07-13 22:24:56 PDT
Minefields "<a>1<button>2</a>3</button>" behavior is wrong, update results
Comment 1 Eric Seidel (no email) 2010-07-13 22:28:50 PDT
Actually,  I now realize that the LegacyHTMLTreeBuilder matches minefield's behavior.  Maybe I read the HTML5 spec wrong?

I've filed a bug with Mozilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=578568
Comment 2 Eric Seidel (no email) 2010-07-13 22:32:04 PDT
I'm still pretty certain that Minefield's behavior violates HTML5.

As far as I can tell, when you hit the </a> the adoption agency
algorithm does not run because of:

"If there is no such node, or, if that node is also in the stack of
open elements but the element is not in scope, then this is a parse
error; ignore the token, and abort these steps."

There is an <a> in the open elements, but its not in scope, because
<button> is a scope marker.

So the </a> is just ignored, and the 3 ends up inside <button> and is
coalesced.
Comment 3 Eric Seidel (no email) 2010-07-13 22:33:04 PDT
Ahha.  The spec has changed:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9496
Comment 4 Eric Seidel (no email) 2010-07-13 22:34:14 PDT
See also:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9829
Comment 5 Eric Seidel (no email) 2010-07-13 22:50:01 PDT
We need to implement this diff:
http://html5.org/tools/web-apps-tracker?from=5031&to=5032
Comment 6 Adam Barth 2010-07-21 14:47:33 PDT
Created attachment 62232 [details]
Patch
Comment 7 Eric Seidel (no email) 2010-07-21 15:46:33 PDT
Comment on attachment 62232 [details]
Patch

There was discussion between Henri and Ian just today about rolling out this spec change, making me wary of trying to do anything here yet.
Comment 8 Adam Barth 2010-07-21 15:55:31 PDT
I think we should track the spec.  If the spec changes again, we can change the code again too.
Comment 9 Eric Seidel (no email) 2010-07-21 17:31:02 PDT
Comment on attachment 62232 [details]
Patch

OK.  There was talk of reverting this change in the spec... but we can always revert this revision too.  Sigh.
Comment 10 Adam Barth 2010-07-21 18:00:54 PDT
Comment on attachment 62232 [details]
Patch

Clearing flags on attachment: 62232

Committed r63868: <http://trac.webkit.org/changeset/63868>
Comment 11 Adam Barth 2010-07-21 18:01:01 PDT
All reviewed patches have been landed.  Closing bug.