Bug 42222 – reconstructActiveFormElements should reconstruct attributes as well

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

reconstructActiveFormElements should reconstruct attributes instead

[Eric Seidel (no email)]

Created attachment 61453 [details]
Patch

[Adam Barth]

Comment on attachment 61453 [details]
Patch

LayoutTests/ChangeLog:5
 +          reconstructActiveFormElements should reconstruct attributes instead
instead?

LayoutTests/html5lib/resources/adoption01.dat:163
 +  |           "document.getElementById("A").id = "B""
Nice test.  Will this cause problems for us when we upstream these tests?  We might want to separate tests that require scripts into their own dat file.

WebCore/html/HTMLConstructionSite.cpp:303
 +  namespace {
Please place this block at the top of the file.

WebCore/html/HTMLConstructionSite.h:67
 +      // Used by the adoption agency.
Please remove this comment.

[Eric Seidel (no email)]

(In reply to comment #2)
> (From update of attachment 61453 [details])
> LayoutTests/ChangeLog:5
>  +          reconstructActiveFormElements should reconstruct attributes instead
> instead?

Fixed.

> LayoutTests/html5lib/resources/adoption01.dat:163
>  +  |           "document.getElementById("A").id = "B""
> Nice test.  Will this cause problems for us when we upstream these tests?  We might want to separate tests that require scripts into their own dat file.

I think we should do that when we understand the upstreaming requirements.

> WebCore/html/HTMLConstructionSite.cpp:303
>  +  namespace {
> Please place this block at the top of the file.

Why?

> WebCore/html/HTMLConstructionSite.h:67
>  +      // Used by the adoption agency.
> Please remove this comment.

OK.  Fixed.

[Eric Seidel (no email)]

Committed r63338: <http://trac.webkit.org/changeset/63338>