Summary: | reconstructActiveFormElements should reconstruct attributes as well | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41123 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-07-13 18:15:30 PDT
Created attachment 61453 [details]
Patch
Comment on attachment 61453 [details]
Patch
LayoutTests/ChangeLog:5
+ reconstructActiveFormElements should reconstruct attributes instead
instead?
LayoutTests/html5lib/resources/adoption01.dat:163
+ | "document.getElementById("A").id = "B""
Nice test. Will this cause problems for us when we upstream these tests? We might want to separate tests that require scripts into their own dat file.
WebCore/html/HTMLConstructionSite.cpp:303
+ namespace {
Please place this block at the top of the file.
WebCore/html/HTMLConstructionSite.h:67
+ // Used by the adoption agency.
Please remove this comment.
(In reply to comment #2) > (From update of attachment 61453 [details]) > LayoutTests/ChangeLog:5 > + reconstructActiveFormElements should reconstruct attributes instead > instead? Fixed. > LayoutTests/html5lib/resources/adoption01.dat:163 > + | "document.getElementById("A").id = "B"" > Nice test. Will this cause problems for us when we upstream these tests? We might want to separate tests that require scripts into their own dat file. I think we should do that when we understand the upstreaming requirements. > WebCore/html/HTMLConstructionSite.cpp:303 > + namespace { > Please place this block at the top of the file. Why? > WebCore/html/HTMLConstructionSite.h:67 > + // Used by the adoption agency. > Please remove this comment. OK. Fixed. Committed r63338: <http://trac.webkit.org/changeset/63338> |