Summary: | [chromium] Autofill menu shows seperator at the wrong place when an entry is deleted | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Scott Violet <sky> | ||||||
Component: | WebKit Misc. | Assignee: | Scott Violet <sky> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dhollowa, jhawkins, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Scott Violet
2010-07-13 16:32:41 PDT
Created attachment 61430 [details]
Initial fix
LGTM Comment on attachment 61430 [details] Initial fix > Index: ChangeLog > + * ../../WebKit/chromium/src/AutoFillPopupMenuClient.cpp: > A few probloems: 1. The is either the wrong ChangeLog or else this patch is malformed. It should be the ChangeLog at WebKit/chromium/ChangeLog. 2. The path in the ChangeLog is messed up. 3. The function being modified is missing in the ChangeLog. My bad if I missed any of these things before. Lastly,it is nice to give a *small* comment by the function in the ChangeLog to explain what was done. (It looks like the change involves account for the separator index.) Created attachment 61539 [details]
Addresses review feedback
Adds call to popupmenuclient to make sure the removal is allowed. Without this the WebViewClient was notified even if the remove wasn't allowed.
Patch set 2 LGTM, much better. LGTM. Comment on attachment 61539 [details] Addresses review feedback Clearing flags on attachment: 61539 Committed r63395: <http://trac.webkit.org/changeset/63395> All reviewed patches have been landed. Closing bug. |