Bug 42163

Summary:

Add tests to check if WebSocket's challenge value is random

Product:

WebKit

Reporter:

Yuta Kitamura <yutak>

Component:

WebCore Misc.

Assignee:

Yuta Kitamura <yutak>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, commit-queue, eric, ukai, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Yuta Kitamura

Reported 2010-07-13 06:47:21 PDT

Chromium has a bug that it always sends a same challenge value due to inability to generate a random value in a worker process. We need to add a test to confirm whether the bug is fixed or not. Original bug: http://crbug.com/47390

Attachments
Patch (8.59 KB, patch) 2010-07-13 07:03 PDT, Yuta Kitamura	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yuta Kitamura

Comment 1 2010-07-13 07:03:42 PDT

Created attachment 61368 [details] Patch

Alexey Proskuryakov

Comment 2 2010-07-13 09:42:42 PDT

Comment on attachment 61368 [details] Patch I don't think that requiring strict comparison is formally correct. Is there anything in specs that disallows MessageEvent.data return a String object? r=me, since it's at least testing for our current behavior, and the behavior is unlikely to change.

Fumitoshi Ukai

Comment 3 2010-07-13 18:19:23 PDT

Comment on attachment 61368 [details] Patch LGTM

WebKit Commit Bot

Comment 4 2010-07-14 02:35:58 PDT

Comment on attachment 61368 [details] Patch Clearing flags on attachment: 61368 Committed r63298: <http://trac.webkit.org/changeset/63298>

WebKit Commit Bot

Comment 5 2010-07-14 02:36:04 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 6 2010-07-14 03:39:54 PDT

http://trac.webkit.org/changeset/63298 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/63298 http://trac.webkit.org/changeset/63299 http://trac.webkit.org/changeset/63300

Fumitoshi Ukai

Comment 7 2010-07-14 03:53:13 PDT

(In reply to comment #6) > http://trac.webkit.org/changeset/63298 might have broken Chromium Mac Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/63298 > http://trac.webkit.org/changeset/63299 > http://trac.webkit.org/changeset/63300 63298 and 63299 add test only, so 63300 should be blamed.

Note You need to log in before you can comment on or make changes to this bug.