Summary: | Fix line number handling in HTMLTreeBuilder to fix a zillion layout tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, sam, tonyg, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41123 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-07-12 22:37:31 PDT
Created attachment 61328 [details]
Patch
Comment on attachment 61328 [details]
Patch
This whole +1 thing is out of control. Can we use the type system to make this easier? Can we just agree on either 0 or 1 based?
Interesting thought. We could use the type system to convert from parser line numbers to script line numbers. I completely agree that the +1 thing is out of control. Comment on attachment 61328 [details] Patch Clearing flags on attachment: 61328 Committed r63180: <http://trac.webkit.org/changeset/63180> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/63180 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/63178 http://trac.webkit.org/changeset/63179 http://trac.webkit.org/changeset/63180 http://trac.webkit.org/changeset/63181 |