Bug 42138

Summary: Fix typo in "close the cell" which caused assertion
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch abarth: review+, commit-queue: commit-queue-

Description Eric Seidel (no email) 2010-07-12 21:45:40 PDT
Fix typo in "close the cell" which caused assertion
Comment 1 Eric Seidel (no email) 2010-07-12 21:46:26 PDT
Created attachment 61322 [details]
Patch
Comment 2 Adam Barth 2010-07-12 22:53:43 PDT
Comment on attachment 61322 [details]
Patch

You've got to put the table in the table scope, apparently.
Comment 3 WebKit Commit Bot 2010-07-12 23:26:28 PDT
Comment on attachment 61322 [details]
Patch

Rejecting patch 61322 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20653 test cases.
html5lib/runner.html -> failed

Exiting early after 1 failures. 15520 tests run.
279.46s total testing time

15519 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
12 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/3506203
Comment 4 Eric Seidel (no email) 2010-07-13 01:23:30 PDT
Committed r63183: <http://trac.webkit.org/changeset/63183>
Comment 5 WebKit Review Bot 2010-07-13 01:42:31 PDT
http://trac.webkit.org/changeset/63183 might have broken GTK Linux 32-bit Release