Bug 42122

Summary: Adding directional property enums back into CSSComputedStyleDeclaration::getPropertyCSSValue
Product: WebKit Reporter: Albert J. Wong <ajwong>
Component: WebCore Misc.Assignee: Albert J. Wong <ajwong>
Status: RESOLVED FIXED    
Severity: Normal CC: arv
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
add enums back into switch. jianli: review+

Albert J. Wong
Reported 2010-07-12 17:51:33 PDT
Chromium build needs all enum values represented inside a switch statement or else it throws an error. Adding in the enum values handled by resolveDirectionAwareProperty() into the switch statement with an ASSERT_NOT_REACHED() to make the compiler happy.
Attachments
add enums back into switch. (1.86 KB, patch)
2010-07-12 17:57 PDT, Albert J. Wong 		jianli: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Albert J. Wong
Comment 1 2010-07-12 17:57:17 PDT
Created attachment 61304 [details] add enums back into switch.
Erik Arvidsson
Comment 2 2010-07-12 18:00:43 PDT
Comment on attachment 61304 [details] add enums back into switch. Looks good with the following exception + Reviewed by NOBODY (OOPS!). Change to "Unreviewed, build fix."
Jian Li
Comment 3 2010-07-12 18:12:23 PDT
Comment on attachment 61304 [details] add enums back into switch. r=me Generally looks good. Before landing your patch, please add more details to ChangeLog to describe why you need to add back enums.
Albert J. Wong
Comment 4 2010-07-12 18:15:35 PDT
Landed as r63153 with beefed up changelog. Resolving.
Note You need to log in before you can comment on or make changes to this bug.