Bug 42122

Summary: Adding directional property enums back into CSSComputedStyleDeclaration::getPropertyCSSValue
Product: WebKit Reporter: Albert J. Wong <ajwong>
Component: WebCore Misc.Assignee: Albert J. Wong <ajwong>
Status: RESOLVED FIXED    
Severity: Normal CC: arv
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
add enums back into switch. jianli: review+

Description Albert J. Wong 2010-07-12 17:51:33 PDT 
Chromium build needs all enum values represented inside a switch statement or else it throws an error.

Adding in the enum values handled by resolveDirectionAwareProperty() into the switch statement with an ASSERT_NOT_REACHED() to make the compiler happy.
Comment 1 Albert J. Wong 2010-07-12 17:57:17 PDT 
Created attachment 61304 [details]
add enums back into switch.
Comment 2 Erik Arvidsson 2010-07-12 18:00:43 PDT 
Comment on attachment 61304 [details]
add enums back into switch.

Looks good with the following exception

+        Reviewed by NOBODY (OOPS!).

Change to "Unreviewed, build fix."
Comment 3 Jian Li 2010-07-12 18:12:23 PDT 
Comment on attachment 61304 [details]
add enums back into switch.

r=me

Generally looks good. Before landing your patch, please add more details to ChangeLog to describe why you need to add back enums.
Comment 4 Albert J. Wong 2010-07-12 18:15:35 PDT 
Landed as r63153 with beefed up changelog.

Resolving.