Bug 42014

Summary: Tidy up lexer token ids
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Oliver Hunt
Reported 2010-07-09 17:54:14 PDT
Tidy up lexer token ids
Attachments
Patch (50.57 KB, patch)
2010-07-09 17:55 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (43.80 KB, patch)
2010-07-09 18:11 PDT, Oliver Hunt 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-07-09 17:55:51 PDT
Created attachment 61127 [details] Patch
Darin Adler
Comment 2 2010-07-09 17:59:01 PDT
Comment on attachment 61127 [details] Patch You need to change parseEQUALmentExpression, m_EQUALmentCount, and initialEQUALments back. Also, why do these token enum values all need TO SHOUT ALL THE TIME. I CAN HEAR THEM EVEN IN MIXED CASE. Typically people do that with macros because they are so dangerous, but if they’re just normal C objects I suggest not using all capitals.
Oliver Hunt
Comment 3 2010-07-09 18:11:30 PDT
Created attachment 61130 [details] Patch
Gavin Barraclough
Comment 4 2010-07-09 18:19:18 PDT
Comment on attachment 61130 [details] Patch r+, assuming you've convinced Darin that the level of SHOUTiness is okay.
Oliver Hunt
Comment 5 2010-07-09 18:26:22 PDT
Committed r63024
WebKit Review Bot
Comment 6 2010-07-09 19:07:30 PDT
http://trac.webkit.org/changeset/63024 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/63024 http://trac.webkit.org/changeset/63025
Zoltan Herczeg
Comment 7 2010-07-09 23:38:49 PDT
Uh, this patch will conflict with my patch submitted two days ago: https://bugs.webkit.org/show_bug.cgi?id=41845 I will resolve the conflict on Monday, but any thoughts welcome.
Oliver Hunt
Comment 8 2010-07-10 12:30:35 PDT
(In reply to comment #7) > Uh, this patch will conflict with my patch submitted two days ago: > https://bugs.webkit.org/show_bug.cgi?id=41845 > > I will resolve the conflict on Monday, but any thoughts welcome. Argh, sorry i thought i had reviewed that :-( I can have a look at resolving the conflicts if you want?
Zoltan Herczeg
Comment 9 2010-07-10 12:48:27 PDT
> I can have a look at resolving the conflicts if you want? No need, thanks. This will be an easy task (hopefully). Will submit the patch on Monday.
Note You need to log in before you can comment on or make changes to this bug.