Bug 41994

Summary: Handle setting of drawing and event models
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-07-09 14:45:48 PDT
Handle setting of drawing and event models
Attachments
Patch (8.48 KB, patch)
2010-07-09 14:48 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-07-09 14:48:17 PDT
Created attachment 61103 [details] Patch
WebKit Review Bot
Comment 2 2010-07-09 14:49:11 PDT
Attachment 61103 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:42: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:64: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:130: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:226: NPN_SetValue is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:230: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 5 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-07-09 15:08:44 PDT
Committed r63000: <http://trac.webkit.org/changeset/63000>
Note You need to log in before you can comment on or make changes to this bug.