Bug 41994 - Handle setting of drawing and event models
Summary: Handle setting of drawing and event models
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 14:45 PDT by Anders Carlsson
Modified: 2010-07-09 15:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.48 KB, patch)
2010-07-09 14:48 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-07-09 14:45:48 PDT 
Handle setting of drawing and event models
Comment 1 Anders Carlsson 2010-07-09 14:48:17 PDT 
Created attachment 61103 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-09 14:49:11 PDT 
Attachment 61103 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:42:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:64:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.cpp:130:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:226:  NPN_SetValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:230:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-07-09 15:08:44 PDT 
Committed r63000: <http://trac.webkit.org/changeset/63000>