Bug 41988

Summary: [QT] WebKit fails to build against Qt QPA / Lighthouse
Product: WebKit Reporter: Jamey Hicks <jamey.hicks>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Enhancement CC: annulen, benjamin, ojan
Priority: P5 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch to fix build against Qt Lighthouse/QPA
none
patch to fix build against Qt Lighthouse/QPA
none
patch updated with changelog hausmann: review-

Jamey Hicks
Reported 2010-07-09 14:27:22 PDT
Created attachment 61096 [details] patch to fix build against Qt Lighthouse/QPA If building WebKit against Qt Lighthouse with no X headers, then plugin support fails to compile. The attached patch adds embedded to CONFIG if qpa is in QT_CONFIG.
Attachments
patch to fix build against Qt Lighthouse/QPA (400 bytes, patch)
2010-07-09 14:27 PDT, Jamey Hicks 		no flags
DetailsFormatted DiffDiff
patch to fix build against Qt Lighthouse/QPA (400 bytes, application/octet-stream)
2010-07-09 14:30 PDT, Jamey Hicks 		no flags
Details
patch updated with changelog (1.03 KB, patch)
2010-07-12 06:18 PDT, Jamey Hicks 		hausmann: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jamey Hicks
Comment 1 2010-07-09 14:30:48 PDT
Created attachment 61097 [details] patch to fix build against Qt Lighthouse/QPA
Jamey Hicks
Comment 2 2010-07-12 06:18:32 PDT
Created attachment 61218 [details] patch updated with changelog Added a ChangeLog
Simon Hausmann
Comment 3 2010-08-04 12:58:18 PDT
Comment on attachment 61218 [details] patch updated with changelog Patch looks fine to me, but could you fix up the ChangeLog? :) The indentation is off, there shouldn't be a "No new tests. (OOPS!)" line and maybe add a "[Qt]" suffix in front of the "enable build against Qt lighthouse" title.
Benjamin Poulain
Comment 4 2011-01-14 11:29:21 PST
Closing, this seems outdated. Feel free to submit an updated patch and I will be happy reopen the task.
Konstantin Tokarev
Comment 5 2011-07-25 04:43:59 PDT
It's quite esy to forward-port this patch, but I don't agree with it. QPA does not mean "embedded" or "without X11"
Note You need to log in before you can comment on or make changes to this bug.