Bug 41982

Summary: Improve vsprops copying for Windows build
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 44050    
Attachments:
Description Flags
Patch
none
Patch none

Description Steve Falkenburg 2010-07-09 13:44:56 PDT
Improve vsprops copying for Windows build
Comment 1 Steve Falkenburg 2010-07-09 13:57:38 PDT
Created attachment 61086 [details]
Patch
Comment 2 Steve Falkenburg 2010-07-09 14:07:56 PDT
Created attachment 61088 [details]
Patch
Comment 3 Adam Roben (:aroben) 2010-07-09 14:39:38 PDT
Comment on attachment 61088 [details]
Patch

> +        When we detect a new SDK, always copy a new set of vsprops files.
> +        Previously, if someone updated their SDK after updating their sources,
> +        they could end up with out-of-date vsprops files.

"SDK" doesn't make much sense to people outside Apple.

I guess another option would be to do this deletion as part of our "get me the latest SDK" script.

r=me
Comment 4 WebKit Commit Bot 2010-08-11 02:41:50 PDT
Comment on attachment 61088 [details]
Patch

Clearing flags on attachment: 61088

Committed r65143: <http://trac.webkit.org/changeset/65143>
Comment 5 WebKit Commit Bot 2010-08-11 02:41:55 PDT
All reviewed patches have been landed.  Closing bug.