Bug 41982 - Improve vsprops copying for Windows build
Summary: Improve vsprops copying for Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks: 44050
  Show dependency treegraph
 
Reported: 2010-07-09 13:44 PDT by Steve Falkenburg
Modified: 2010-08-16 02:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2010-07-09 13:57 PDT, Steve Falkenburg
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2010-07-09 14:07 PDT, Steve Falkenburg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-07-09 13:44:56 PDT
Improve vsprops copying for Windows build
Comment 1 Steve Falkenburg 2010-07-09 13:57:38 PDT
Created attachment 61086 [details]
Patch
Comment 2 Steve Falkenburg 2010-07-09 14:07:56 PDT
Created attachment 61088 [details]
Patch
Comment 3 Adam Roben (:aroben) 2010-07-09 14:39:38 PDT
Comment on attachment 61088 [details]
Patch

> +        When we detect a new SDK, always copy a new set of vsprops files.
> +        Previously, if someone updated their SDK after updating their sources,
> +        they could end up with out-of-date vsprops files.

"SDK" doesn't make much sense to people outside Apple.

I guess another option would be to do this deletion as part of our "get me the latest SDK" script.

r=me
Comment 4 WebKit Commit Bot 2010-08-11 02:41:50 PDT
Comment on attachment 61088 [details]
Patch

Clearing flags on attachment: 61088

Committed r65143: <http://trac.webkit.org/changeset/65143>
Comment 5 WebKit Commit Bot 2010-08-11 02:41:55 PDT
All reviewed patches have been landed.  Closing bug.