Bug 41976

Summary: SelectionController::positionForPlatform should ask EditingBehavior for platform specific behavior
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: DOMAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mrobinson, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 39854    
Bug Blocks:    
Attachments:
Description Flags
Patch v1.
darin: review+
Patch for landing. none

Description Antonio Gomes 2010-07-09 12:30:57 PDT
... instead, it is accessing EditingMacBehavior directly today.
Comment 1 Antonio Gomes 2016-03-08 09:15:14 PST
(In reply to comment #0)
> ... instead, it is accessing EditingMacBehavior directly today.

It's been sitting untouched for over 5.5years, but should be a quick fix. Taking..
Comment 2 Antonio Gomes 2016-03-31 07:15:09 PDT
Created attachment 275277 [details]
Patch v1.
Comment 3 Darin Adler 2016-03-31 08:50:40 PDT
Comment on attachment 275277 [details]
Patch v1.

View in context: https://bugs.webkit.org/attachment.cgi?id=275277&action=review

> Source/WebCore/editing/FrameSelection.cpp:630
> +    // Mac and iOS.

I don’t think we should add this comment.
Comment 4 Antonio Gomes 2016-03-31 11:20:54 PDT
Created attachment 275303 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2016-03-31 11:50:53 PDT
Comment on attachment 275303 [details]
Patch for landing.

Clearing flags on attachment: 275303

Committed r198904: <http://trac.webkit.org/changeset/198904>
Comment 6 WebKit Commit Bot 2016-03-31 11:50:57 PDT
All reviewed patches have been landed.  Closing bug.