Summary: | SelectionController::positionForPlatform should ask EditingBehavior for platform specific behavior | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||||
Component: | DOM | Assignee: | Antonio Gomes <tonikitoo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, mrobinson, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Bug Depends on: | 39854 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Antonio Gomes
2010-07-09 12:30:57 PDT
(In reply to comment #0) > ... instead, it is accessing EditingMacBehavior directly today. It's been sitting untouched for over 5.5years, but should be a quick fix. Taking.. Created attachment 275277 [details]
Patch v1.
Comment on attachment 275277 [details] Patch v1. View in context: https://bugs.webkit.org/attachment.cgi?id=275277&action=review > Source/WebCore/editing/FrameSelection.cpp:630 > + // Mac and iOS. I don’t think we should add this comment. Created attachment 275303 [details]
Patch for landing.
Comment on attachment 275303 [details] Patch for landing. Clearing flags on attachment: 275303 Committed r198904: <http://trac.webkit.org/changeset/198904> All reviewed patches have been landed. Closing bug. |