Bug 41976 - SelectionController::positionForPlatform should ask EditingBehavior for platform specific behavior
Summary: SelectionController::positionForPlatform should ask EditingBehavior for platf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on: 39854
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-09 12:30 PDT by Antonio Gomes
Modified: 2016-03-31 11:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1. (3.62 KB, patch)
2016-03-31 07:15 PDT, Antonio Gomes 		darin: review+
Details | Formatted Diff | Diff
Patch for landing. (3.59 KB, patch)
2016-03-31 11:20 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-07-09 12:30:57 PDT 
... instead, it is accessing EditingMacBehavior directly today.
Comment 1 Antonio Gomes 2016-03-08 09:15:14 PST 
(In reply to comment #0)
> ... instead, it is accessing EditingMacBehavior directly today.

It's been sitting untouched for over 5.5years, but should be a quick fix. Taking..
Comment 2 Antonio Gomes 2016-03-31 07:15:09 PDT 
Created attachment 275277 [details]
Patch v1.
Comment 3 Darin Adler 2016-03-31 08:50:40 PDT 
Comment on attachment 275277 [details]
Patch v1.

View in context: https://bugs.webkit.org/attachment.cgi?id=275277&action=review

> Source/WebCore/editing/FrameSelection.cpp:630
> +    // Mac and iOS.

I don’t think we should add this comment.
Comment 4 Antonio Gomes 2016-03-31 11:20:54 PDT 
Created attachment 275303 [details]
Patch for landing.
Comment 5 WebKit Commit Bot 2016-03-31 11:50:53 PDT 
Comment on attachment 275303 [details]
Patch for landing.

Clearing flags on attachment: 275303

Committed r198904: <http://trac.webkit.org/changeset/198904>
Comment 6 WebKit Commit Bot 2016-03-31 11:50:57 PDT 
All reviewed patches have been landed.  Closing bug.