Bug 41944

Summary:

commit-queue should merge to TOT when checkout needs update

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+

Description Adam Barth 2010-07-09 02:16:33 PDT

commit-queue should merge to TOT when checkout needs update

Comment 1 Adam Barth 2010-07-09 02:23:18 PDT

Created attachment 61022 [details]
Patch

Comment 2 WebKit Review Bot 2010-07-09 02:24:23 PDT

Attachment 61022 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py:44:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Eric Seidel (no email) 2010-07-09 02:31:07 PDT

Comment on attachment 61022 [details]
Patch

Looks fine.  RetryCommand is kinda a funny name.  Makes me think it's a  "Command" subclass.

Comment 4 Adam Barth 2010-07-09 02:40:37 PDT

Committed r62923: <http://trac.webkit.org/changeset/62923>