Bug 41944 - commit-queue should merge to TOT when checkout needs update
Summary: commit-queue should merge to TOT when checkout needs update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-09 02:16 PDT by Adam Barth
Modified: 2010-07-09 02:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.94 KB, patch)
2010-07-09 02:23 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-09 02:16:33 PDT 
commit-queue should merge to TOT when checkout needs update
Comment 1 Adam Barth 2010-07-09 02:23:18 PDT 
Created attachment 61022 [details]
Patch
Comment 2 WebKit Review Bot 2010-07-09 02:24:23 PDT 
Attachment 61022 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py:44:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2010-07-09 02:31:07 PDT 
Comment on attachment 61022 [details]
Patch

Looks fine.  RetryCommand is kinda a funny name.  Makes me think it's a  "Command" subclass.
Comment 4 Adam Barth 2010-07-09 02:40:37 PDT 
Committed r62923: <http://trac.webkit.org/changeset/62923>