Bug 41935

Summary: Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880
Product: WebKit Reporter: Albert J. Wong <ajwong>
Component: WebCore Misc.Assignee: Albert J. Wong <ajwong>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add in timeRangesEnable() zimmermann: review+

Albert J. Wong
Reported 2010-07-09 00:16:49 PDT
Revision 62880 made TimeRanges EnabledAtRuntime. This requires a corresponding function, RuntimeEnabledFeatures::timeRangesEnabled(), to be added.
Attachments
Add in timeRangesEnable() (1.71 KB, patch)
2010-07-09 00:28 PDT, Albert J. Wong 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Albert J. Wong
Comment 1 2010-07-09 00:28:48 PDT
Created attachment 61006 [details] Add in timeRangesEnable()
Nikolas Zimmermann
Comment 2 2010-07-09 00:36:43 PDT
Comment on attachment 61006 [details] Add in timeRangesEnable() LGTM, r=me.We were both not 100% sure whether timeRangesEnabled() should be 1:1 coupled with the MediaPlayer availability. But as TimeRanges is conditional=video, and it's also exposed only if VIDEO is enabled, it seems fine.
Albert J. Wong
Comment 3 2010-07-09 02:28:16 PDT
Committed as r62920.
Note You need to log in before you can comment on or make changes to this bug.