Bug 41880

Summary: [Qt] [WebKit2] Make QWKPage call _q_webActionTriggered as a private slot
Product: WebKit Reporter: Diego Gonzalez <diegohcg>
Component: WebKit2Assignee: Diego Gonzalez <diegohcg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch kenneth: review+, commit-queue: commit-queue-

Description Diego Gonzalez 2010-07-08 11:26:53 PDT
Make possible to handle the slots for web actions
Comment 1 Diego Gonzalez 2010-07-08 11:52:27 PDT
Created attachment 60919 [details]
Patch
Comment 2 WebKit Commit Bot 2010-07-09 08:14:05 PDT
Comment on attachment 60919 [details]
Patch

Rejecting patch 60919 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/UIProcess/API/qt/qwkpage.cpp
patching file WebKit2/UIProcess/API/qt/qwkpage.h
Hunk #1 FAILED at 65.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.h.rej

Full output: http://webkit-commit-queue.appspot.com/results/3433053
Comment 3 Diego Gonzalez 2010-07-09 09:31:06 PDT
Landed manually at r62959 https://trac.webkit.org/changeset/62959