Bug 41811

Summary: add --exit-after-n-crashes to run-webkit-tests
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch levin: review+

Ojan Vafai
Reported 2010-07-07 16:20:09 PDT
add --exit-after-n-crashes to run-webkit-tests
Attachments
Patch (4.60 KB, patch)
2010-07-07 16:21 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.83 KB, patch)
2010-07-07 16:32 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2010-07-07 16:35 PDT, Ojan Vafai 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-07-07 16:21:04 PDT
Created attachment 60798 [details] Patch
Ojan Vafai
Comment 2 2010-07-07 16:32:21 PDT
Created attachment 60801 [details] Patch
Ojan Vafai
Comment 3 2010-07-07 16:35:33 PDT
Created attachment 60802 [details] Patch
Ojan Vafai
Comment 4 2010-07-07 16:48:59 PDT
Committed r62728: <http://trac.webkit.org/changeset/62728>
Dirk Pranke
Comment 5 2010-07-07 17:43:05 PDT
drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures?
Ojan Vafai
Comment 6 2010-07-07 17:51:25 PDT
(In reply to comment #5) > drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures? There was discussion on webkit-dev that was inconclusive. --exit-after-n-failures is useful to keep the commit-queue fast.
Note You need to log in before you can comment on or make changes to this bug.