WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41811
add --exit-after-n-crashes to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=41811
Summary
add --exit-after-n-crashes to run-webkit-tests
Ojan Vafai
Reported
2010-07-07 16:20:09 PDT
add --exit-after-n-crashes to run-webkit-tests
Attachments
Patch
(4.60 KB, patch)
2010-07-07 16:21 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Patch
(5.83 KB, patch)
2010-07-07 16:32 PDT
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
Patch
(5.78 KB, patch)
2010-07-07 16:35 PDT
,
Ojan Vafai
levin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2010-07-07 16:21:04 PDT
Created
attachment 60798
[details]
Patch
Ojan Vafai
Comment 2
2010-07-07 16:32:21 PDT
Created
attachment 60801
[details]
Patch
Ojan Vafai
Comment 3
2010-07-07 16:35:33 PDT
Created
attachment 60802
[details]
Patch
Ojan Vafai
Comment 4
2010-07-07 16:48:59 PDT
Committed
r62728
: <
http://trac.webkit.org/changeset/62728
>
Dirk Pranke
Comment 5
2010-07-07 17:43:05 PDT
drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures?
Ojan Vafai
Comment 6
2010-07-07 17:51:25 PDT
(In reply to
comment #5
)
> drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures?
There was discussion on webkit-dev that was inconclusive. --exit-after-n-failures is useful to keep the commit-queue fast.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug