Bug 41811 - add --exit-after-n-crashes to run-webkit-tests
Summary: add --exit-after-n-crashes to run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 16:20 PDT by Ojan Vafai
Modified: 2010-07-07 17:51 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.60 KB, patch)
2010-07-07 16:21 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (5.83 KB, patch)
2010-07-07 16:32 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (5.78 KB, patch)
2010-07-07 16:35 PDT, Ojan Vafai
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-07-07 16:20:09 PDT
add --exit-after-n-crashes to run-webkit-tests
Comment 1 Ojan Vafai 2010-07-07 16:21:04 PDT
Created attachment 60798 [details]
Patch
Comment 2 Ojan Vafai 2010-07-07 16:32:21 PDT
Created attachment 60801 [details]
Patch
Comment 3 Ojan Vafai 2010-07-07 16:35:33 PDT
Created attachment 60802 [details]
Patch
Comment 4 Ojan Vafai 2010-07-07 16:48:59 PDT
Committed r62728: <http://trac.webkit.org/changeset/62728>
Comment 5 Dirk Pranke 2010-07-07 17:43:05 PDT
drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures?
Comment 6 Ojan Vafai 2010-07-07 17:51:25 PDT
(In reply to comment #5)
> drive-by after-the-fact review comment: are we sure that we want to support both switches? Your ChangeLog indicated why --exit-after-n-crashes was preferable to --exit-after-n-failures. Are we sure that there are still cases where we want to also support -n-failures?

There was discussion on webkit-dev that was inconclusive. --exit-after-n-failures is useful to keep the commit-queue fast.